Try with just the altq, queue and pass rules from the example. Reload the ruleset and flush all existing state entries (pfctl -Fs), as only newly established connections will be queued according to the new ruleset. Then try a single download and upload over TCP (ftp, http, etc.) concurrently.
If that works, you can try the same with your real ruleset, I'd only add the queue (q_def, q_pri) to the pass rules on the external interface, and make sure you're adding it to all of them that create the TCP connections. Daniel