On Thu, Jul 20, 2017 at 2:18 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote:
> Hello Dave, > Did you use the latest one patch we sent? > We realised that this was an issue in the second email we sent. > Just checked again, and yes, that was the third and latest version I've received.. > Thanks > Joao > > On Thu, Jul 20, 2017, 8:15 AM Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> On Wed, Jul 19, 2017 at 8:33 PM, Shruti Iyer <si...@pivotal.io> wrote: >> >>> Hi again! >>> >>> Attached are the most updated patches. We found an issue with the >>> previous implementation. So we generated the new patches. >>> >> >> The 01 patch fails linting: >> >> /Users/dpage/git/pgadmin4/web/regression/javascript/history/ >> query_history_spec.jsx >> 188:9 error Expected indentation of 10 spaces but found 8 indent >> 196:7 error Expected indentation of 8 spaces but found 6 indent >> 198:7 error Expected indentation of 8 spaces but found 6 indent >> 202:12 error Expected indentation of 10 spaces but found 11 indent >> 205:11 error Expected indentation of 8 spaces but found 10 indent >> 212:9 error Expected indentation of 10 spaces but found 8 indent >> 214:11 error Expected indentation of 8 spaces but found 10 indent >> 217:11 error Expected indentation of 12 spaces but found 10 indent >> 219:9 error Expected indentation of 6 spaces but found 8 indent >> >> Can you please fix that up and double-check the tests pass? >> >> Thanks. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
