Hi, Currently if user clicks on empty white area below history entry then arrow navigation does not work. Attached patch fixes this issue.
[image: Inline image 1] -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jul 21, 2017 at 1:21 AM, Dave Page <dp...@pgadmin.org> wrote: > Ah, OK - I was working on them one at a time. > > Thanks, patches applied! > > On Thu, Jul 20, 2017 at 7:01 PM, Matthew Kleiman <mklei...@pivotal.io> > wrote: > >> Hi Dave, >> >> In our previous email, the second patch fixed the linting issue from the >> first patch. >> However, we've remade these two patches so they both pass the linting >> test. >> >> Thanks, >> Matt and João >> >> >> On Thu, Jul 20, 2017 at 12:56 PM, Dave Page <dp...@pgadmin.org> wrote: >> >>> >>> >>> On Thu, Jul 20, 2017 at 2:18 PM, Joao De Almeida Pereira < >>> jdealmeidapere...@pivotal.io> wrote: >>> >>>> Hello Dave, >>>> Did you use the latest one patch we sent? >>>> We realised that this was an issue in the second email we sent. >>>> >>> Just checked again, and yes, that was the third and latest version I've >>> received.. >>> >>> >>> >>>> Thanks >>>> Joao >>>> >>>> On Thu, Jul 20, 2017, 8:15 AM Dave Page <dp...@pgadmin.org> wrote: >>>> >>>>> Hi >>>>> >>>>> On Wed, Jul 19, 2017 at 8:33 PM, Shruti Iyer <si...@pivotal.io> wrote: >>>>> >>>>>> Hi again! >>>>>> >>>>>> Attached are the most updated patches. We found an issue with the >>>>>> previous implementation. So we generated the new patches. >>>>>> >>>>> >>>>> The 01 patch fails linting: >>>>> >>>>> /Users/dpage/git/pgadmin4/web/regression/javascript/history/ >>>>> query_history_spec.jsx >>>>> 188:9 error Expected indentation of 10 spaces but found 8 indent >>>>> 196:7 error Expected indentation of 8 spaces but found 6 indent >>>>> 198:7 error Expected indentation of 8 spaces but found 6 indent >>>>> 202:12 error Expected indentation of 10 spaces but found 11 indent >>>>> 205:11 error Expected indentation of 8 spaces but found 10 indent >>>>> 212:9 error Expected indentation of 10 spaces but found 8 indent >>>>> 214:11 error Expected indentation of 8 spaces but found 10 indent >>>>> 217:11 error Expected indentation of 12 spaces but found 10 indent >>>>> 219:9 error Expected indentation of 6 spaces but found 8 >>>>> indent >>>>> >>>>> Can you please fix that up and double-check the tests pass? >>>>> >>>>> Thanks. >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
diff --git a/web/pgadmin/static/jsx/history/query_history.jsx b/web/pgadmin/static/jsx/history/query_history.jsx index a276e53..940731c 100644 --- a/web/pgadmin/static/jsx/history/query_history.jsx +++ b/web/pgadmin/static/jsx/history/query_history.jsx @@ -172,13 +172,14 @@ export default class QueryHistory extends React.Component { <SplitPane defaultSize="50%" split="vertical" pane1Style={queryEntryListDivStyle} pane2Style={queryDetailDivStyle}> <div id='query_list' - className="query-history"> + className="query-history" + onKeyDown={this.navigateUpAndDown} + tabIndex='0'> <ul> {this.retrieveOrderedHistory() .map((entry, index) => - <li key={index} className='list-item' tabIndex='0' - onClick={this.onClickHandler.bind(this, index)} - onKeyDown={this.navigateUpAndDown}> + <li key={index} className='list-item' + onClick={this.onClickHandler.bind(this, index)}> <QueryHistoryEntry historyEntry={entry} isSelected={index == this.state.selectedEntry}/> diff --git a/web/pgadmin/static/scss/sqleditor/_history.scss b/web/pgadmin/static/scss/sqleditor/_history.scss index ed0c10f..942af03 100644 --- a/web/pgadmin/static/scss/sqleditor/_history.scss +++ b/web/pgadmin/static/scss/sqleditor/_history.scss @@ -1,4 +1,5 @@ .query-history { + height: 100%; .list-item { border-bottom: 1px solid $color-gray-3; }