Dave Page wrote:



-----Original Message-----
From: Andreas Pflug [mailto:[EMAIL PROTECTED] Sent: 09 September 2003 11:50
To: Dave Page
Cc: Hiroshi Saito; [EMAIL PROTECTED]
Subject: Re: [pgadmin-hackers] pgAggregate problem any function



Hm,


looking at the patch and the weird pgsql behaviour documented below I doubt that this is the ultimate fix.
I suspect that
a) this should be handled in qtIdent()
b) other keywords might be affected, e.g. 'char'



We looked at this in pga2 (and I think Frank did implement something in the end). The problem is that there is a huge list of reserved words that need checking (http://www.postgresql.org/docs/7.3/static/sql-keywords-appendix.html), 90% of which noone is ever likely to name a type or domain after. Is it worth the overhead of searching the list in every call to qtIdent?

Didn't want to check all keywords, but there are some treated special, and one of them is "char". I was wondering if "any" will make problems in other places too, that's why I'd like to see it in qtIdent().

Regards,
Andreas



---------------------------(end of broadcast)---------------------------
TIP 7: don't forget to increase your free space map settings

Reply via email to