Dave Page wrote:
-----Original Message-----
From: Andreas Pflug [mailto:[EMAIL PROTECTED]
Sent: 09 September 2003 13:55
To: Dave Page
Cc: Hiroshi Saito; [EMAIL PROTECTED]
Subject: Re: [pgadmin-hackers] pgAggregate problem any function
Dave Page wrote:
I guess we should really check them all. Can we jsut lift
the relevant
bits of
http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/b
ackend/par
s
er/keywords.c?rev=1.141&content-type=text/x-cvsweb-markup, or would you
prefer it was done a different way?
I just added this to qtIdent using the original pgsql files, but I
wasn't too happy with it currently commented out).
Hmm. Currently it breaks the build because parser/keywords.h is missing.
keywords.c istelf has a bunch of additional includes that won't be there
as well.
I added all to cvs, copying them from pgsql or creating dummy ones.
linux not done yet.
We've had no complaints about keywords causing problems anywhere (in
pga2 or pga3), and the aggregate problem is obviously a real one - I
vote we go with Hiroshi's patch for now, and take a closer look for the
next version. The number of places qtIdent is used, I think there is too
much scope to accidently break things in the way you demonstrated above
this close to release.
Agreed.
Regards,
Andreas
---------------------------(end of broadcast)---------------------------
TIP 9: the planner will ignore your desire to choose an index scan if your
joining column's datatypes do not match
