MSVC: Support building for AArch64.

This commit does the following to get tests passing for
MSVC/AArch64:

* Implements spin_delay() with an ISB instruction (like we do for
gcc/clang on AArch64).

* Sets USE_ARMV8_CRC32C unconditionally.  Vendor-supported versions
of Windows for AArch64 require at least ARMv8.1, which is where CRC
extension support became mandatory.

* Implements S_UNLOCK() with _InterlockedExchange().  The existing
implementation for MSVC uses _ReadWriteBarrier() (a compiler
barrier), which is insufficient for this purpose on non-TSO
architectures.

There are likely other changes required to take full advantage of
the hardware (e.g., atomics/arch-arm.h, simd.h,
pg_popcount_aarch64.c), but those can be dealt with later.

Author: Niyas Sait <[email protected]>
Co-authored-by: Greg Burd <[email protected]>
Co-authored-by: Dave Cramer <[email protected]>
Reviewed-by: Michael Paquier <[email protected]>
Reviewed-by: John Naylor <[email protected]>
Reviewed-by: Peter Eisentraut <[email protected]>
Reviewed-by: Andres Freund <[email protected]>
Reviewed-by: Thomas Munro <[email protected]>
Tested-by: Andrew Dunstan <[email protected]>
Discussion: 
https://postgr.es/m/A6152C7C-F5E3-4958-8F8E-7692D259FF2F%40greg.burd.me
Discussion: 
https://postgr.es/m/CAFPTBD-74%2BAEuN9n7caJ0YUnW5A0r-KBX8rYoEJWqFPgLKpzdg%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a516b3f00d7469cbd1885a2c5903fbd62430a2ac

Modified Files
--------------
doc/src/sgml/installation.sgml |  3 ++-
meson.build                    |  6 +++++-
src/include/storage/s_lock.h   | 30 +++++++++++++++++++++++++-----
src/port/pg_crc32c_armv8.c     |  4 ++++
src/tools/msvc_gendef.pl       |  8 ++++----
5 files changed, 40 insertions(+), 11 deletions(-)

Reply via email to