Replace flaky CIC/RI isolation tests with a TAP test The isolation tests for INSERT ON CONFLICT behavior during CREATE INDEX CONCURRENTLY and REINDEX CONCURRENTLY (added by bc32a12e0db2, 2bc7e886fc1b, and 90eae926abbb) were disabled in 77038d6d0b49 due to persistent CI flakiness, after several attempts at stabilization.
This commit removes them and introduces a TAP test in test_misc module (010_index_concurrently_upsert.pl) that covers the same scenarios. This new test should hopefully be more stable while providing assurance that the fixes in all those commits (plus 81f72115cf18) continue to work. Author: Mihail Nikalayeu <[email protected]> Reported-by: Andres Freund <[email protected]> Reviewed-by: Álvaro Herrera <[email protected]> Discussion: https://postgr.es/m/ccssrhafzbp3a3beju3ptyc56a7gbfimj4vwkbokoldofckrc7@bso37rxskjtf Discussion: https://postgr.es/m/cantu0ogv+6wqrzpk241jik4u95s1pw3mcz3rx5zqbfduysz...@mail.gmail.com Discussion: https://postgr.es/m/[email protected] Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/e1c971945d62d3150ecfe353ce7bb4263916b489 Modified Files -------------- src/test/modules/injection_points/Makefile | 8 - .../index-concurrently-upsert-predicate.out | 123 --- .../index-concurrently-upsert-predicate_1.out | 124 --- .../expected/index-concurrently-upsert.out | 123 --- .../expected/index-concurrently-upsert_1.out | 124 --- .../reindex-concurrently-upsert-on-constraint.out | 238 ------ .../reindex-concurrently-upsert-partitioned.out | 238 ------ .../expected/reindex-concurrently-upsert.out | 238 ------ src/test/modules/injection_points/meson.build | 6 - .../specs/index-concurrently-upsert-predicate.spec | 124 --- .../specs/index-concurrently-upsert.spec | 123 --- .../reindex-concurrently-upsert-on-constraint.spec | 110 --- .../reindex-concurrently-upsert-partitioned.spec | 113 --- .../specs/reindex-concurrently-upsert.spec | 111 --- src/test/modules/test_misc/Makefile | 3 + src/test/modules/test_misc/meson.build | 3 + .../test_misc/t/010_index_concurrently_upsert.pl | 902 +++++++++++++++++++++ 17 files changed, 908 insertions(+), 1803 deletions(-)
