Andres Freund <and...@anarazel.de> writes: > If we do this, and I think we should, I'm inclined to also commit a > patch that renames ExplainPropertyLong > and changes its argument type. Because passing long is just plain > unhelpful for 32bit platforms and windows. We should just always use > 64bits here.
+1 --- I'm pretty certain that function predates our requirement that all platforms support int64. > Only thing I wonder is if we shouldn't just *remove* > ExplainPropertyLong and make ExplainPropertyInteger accept 64bits of > input - the effort of passing and printing a 64bit integer will never be > relevant for explain. -0.5 ... everywhere else, we mean "int32" when we say "int", and I don't think it's worth the potential confusion to do it differently here. regards, tom lane