On Sat, Oct 2, 2021 at 6:46 AM Dilip Kumar <dilipbal...@gmail.com> wrote: > I have written two patches, Approach1 is as you described using a > static boolean and Approach2 as a local variable to XLogAssembleRecord > as described by Amit, attached both of them for your reference. > IMHO, either of these approaches looks cleaner.
I agree, and I don't have a strong preference between them. If I were writing code like this from scratch, I would do what 0001 does. But 0002 is arguably more consistent with the existing style. It's kind of hard to judge, at least for me, which is to be preferred. -- Robert Haas EDB: http://www.enterprisedb.com
