On Tue, Sep 21, 2021 at 6:48 PM Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > Document XLOG_INCLUDE_XID a little better > > I noticed that commit 0bead9af484c left this flag undocumented in > XLogSetRecordFlags, which led me to discover that the flag doesn't > actually do what the one comment on it said it does. Improve the > situation by adding some more comments. > > Backpatch to 14, where the aforementioned commit appears.
I'm not sure that saying something is a "hack" is really all that useful as documentation. But more to the point, I think this hack is ugly and needs to be replaced with something less hacky. Amit? -- Robert Haas EDB: http://www.enterprisedb.com