On Wed, Oct 27, 2021 at 5:20 PM Joshua Brindle <joshua.brin...@crunchydata.com> wrote: > > On Wed, Oct 27, 2021 at 5:16 PM Robert Haas <robertmh...@gmail.com> wrote: > > > > On Wed, Oct 27, 2021 at 5:14 PM Joshua Brindle > > <joshua.brin...@crunchydata.com> wrote: > > > Attached is an updated version of the patch to replace > > > is_member_of_role with has_privs_for_role for predefined roles. It > > > does not remove is_member_of_role from acl.h but it does add a warning > > > not to use that function for privilege checking. > > > > > > Please consider this for the upcoming commitfest. > > > > I am not sure I understand what the advantage of this is supposed to be. > > Pre-defined roles currently do not operate the same way other roles do > with respect to inheritance. The patchfile has an explanation and > examples, I wasn't sure if that needed to be repeated in the email or > not.
And FWIW several predefined role patches on the list currently correctly use has_privs_for_role rather than is_memver_of_role so this brings the older roles to be consistent with the newer ones being proposed.