On Tue, Nov 9, 2021 at 7:04 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Tue, Nov 9, 2021 at 12:13 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > > > On Tue, Nov 9, 2021 at 3:08 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > > > > > > 4. It seems now stats_reset entry is not present in > > > pg_stat_subscription_workers? How will users find that information if > > > required? > > > > Users can find it in pg_stat_databases. The same is true for table and > > function statistics -- they don't have stats_reset column but reset > > stats_reset of its entry on pg_stat_database. > > > > Okay, but isn't it better to deal with the reset of subscription > workers via pgstat_recv_resetsinglecounter by introducing subobjectid? > I think that will make code consistent for all database-related stats. >
Agreed. It's better to use the same function internally even if the SQL-callable interfaces are different. Regards, -- Masahiko Sawada EDB: https://www.enterprisedb.com/
