Messages by Thread
-
clamp_row_est avoid infinite
jian he
-
Re: logicalrep_worker_launch -- counting/checking the worker limits
Peter Smith
-
Re: Statistics Import and Export
Jeff Davis
-
Re: Cleanup: remove unused fields from nodes
Michael Paquier
-
datfrozen/relfrozen update race condition
Noah Misch
-
Re: GUC-ify walsender MAX_SEND_SIZE constant
Michael Paquier
-
Re: Direct SSL connection with ALPN and HBA rules
Heikki Linnakangas
-
Re: POC: GROUP BY optimization
Alexander Korotkov
-
Re: POC: GROUP BY optimization
jian he
-
Re: POC: GROUP BY optimization
jian he
-
Re: POC: GROUP BY optimization
jian he
-
Re: POC: GROUP BY optimization
Andrei Lepikhov
-
Re: POC: GROUP BY optimization
jian he
-
Re: POC: GROUP BY optimization
Andrei Lepikhov
-
Re: POC: GROUP BY optimization
jian he
-
Re: POC: GROUP BY optimization
Alexander Korotkov
-
About 0001:,Having overviewed it, I don't see any issues (but I'm the author), except grammatical ones - but I'm not a native to judge it.,Also, the sentence 'turning GROUP BY clauses into pathkeys' is unclear to me. It may be better to write something like: 'building pathkeys by the list of grouping clauses'.,,0002:,The part under USE_ASSERT_CHECKING looks good to me. But the code in group_keys_reorder_by_pathkeys looks suspicious: of course, we do some doubtful work without any possible way to reproduce, but if we envision some duplicated elements in the group_clauses, we should avoid usage of the list_concat_unique_ptr. What's more, why do you not exit from foreach_ptr immediately after SortGroupClause has been found? I think the new_group_clauses should be consistent with the new_group_pathkeys.,,0003:,Looks good,,0004:,I was also thinking about reintroducing the preprocess_groupclause because with the re-arrangement of GROUP-BY clauses according to incoming pathkeys, it doesn't make sense to have a user-defined order—at least while cost_sort doesn't differ costs for alternative column orderings.,So, I'm okay with the code. But why don't you use the same approach with foreach_ptr as before?
Andrei Lepikhov
-
Re: About 0001:,Having overviewed it, I don't see any issues (but I'm the author), except grammatical ones - but I'm not a native to judge it.,Also, the sentence 'turning GROUP BY clauses into pathkeys' is unclear to me. It may be better to write something like: 'building pathkeys by the list of grouping clauses'.,,0002:,The part under USE_ASSERT_CHECKING looks good to me. But the code in group_keys_reorder_by_pathkeys looks suspicious: of course, we do some doubtful work without any possible way to reproduce, but if we envision some duplicated elements in the group_clauses, we should avoid usage of the list_concat_unique_ptr. What's more, why do you not exit from foreach_ptr immediately after SortGroupClause has been found? I think the new_group_clauses should be consistent with the new_group_pathkeys.,,0003:,Looks good,,0004:,I was also thinking about reintroducing the preprocess_groupclause because with the re-arrangement of GROUP-BY clauses according to incoming pathkeys, it d...
Alexander Korotkov
-
Re: POC: GROUP BY optimization
Andrei Lepikhov
-
Re: POC: GROUP BY optimization
Alexander Korotkov
-
Re: POC: GROUP BY optimization
jian he
-
Re: POC: GROUP BY optimization
Alexander Korotkov
-
Re: POC: GROUP BY optimization
Pavel Borisov
-
Re: POC: GROUP BY optimization
Alexander Korotkov
-
Re: POC: GROUP BY optimization
Alexander Korotkov
-
Re: [Doc] Improvements to ddl.sgl Privileges Section and Glossary
David G. Johnston
-
Re: [Doc] Improve hostssl related descriptions and option presentation
David G. Johnston
-
Re: Add new protocol message to change GUCs for usage with future protocol-only GUCs
Jelte Fennema-Nio
-
Re: fix tablespace handling in pg_combinebackup
Thomas Munro
-
Re: DROP OWNED BY fails to clean out pg_init_privs grants
Daniel Gustafsson
-
Re: Why does pgindent's README say to download typedefs.list from the buildfarm?
Nathan Bossart