On Wednesday, November 10, 2021 7:46 AM Peter Smith <smithpb2...@gmail.com> wrote: > > On Tue, Nov 9, 2021 at 2:03 PM tanghy.f...@fujitsu.com > <tanghy.f...@fujitsu.com> wrote: > > > > On Friday, November 5, 2021 1:14 PM, Peter Smith <smithpb2...@gmail.com> > wrote: > > > > > > PSA new set of v37* patches. > > > > > > > Thanks for your patch. I have a problem when using this patch. > > > > The document about "create publication" in patch says: > > > > The <literal>WHERE</literal> clause should contain only columns that are > > part of the primary key or be covered by <literal>REPLICA > > IDENTITY</literal> otherwise, <command>DELETE</command> operations will > not > > be replicated. > > > > But I tried this patch, the columns which could be contained in WHERE clause > must be > > covered by REPLICA IDENTITY, but it doesn't matter if they are part of the > primary key. > > (We can see it in Case 4 of publication.sql, too.) So maybe we should > > modify the > document. > > > > PG Docs is changed in v38-0004 [1]. Please check if it is OK. >
Thanks, this change looks good to me. Regards Tang
