On Fri, Nov 19, 2021 at 1:22 PM Greg Nancarrow <gregn4...@gmail.com> wrote: > > On Fri, Nov 19, 2021 at 5:52 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > Why that Assert will hit? We seem to be always passing 'create' as > > true so it should create a new entry. I think a similar situation can > > happen for functions and it will be probably cleaned in the next > > vacuum cycle. > > > Oops, I missed that too. So at worst, vacuum will clean it up in the > out-of-order SUBSCRIPTIONPURGE,SUBWORKERERROR case. > > But I still think the current code may not correctly handle > first_error_time/last_error_time timestamps if out-of-order > SUBWORKERERROR messages occur, right? >
Yeah in such a case last_error_time can be shown as a time before first_error_time but I don't think that will be a big problem, the next message will fix it. I don't see what we can do about it and the same is true for other cases like pg_stat_archiver where the success and failure times can be out of order. If we want we can remove one of those times but I don't think this happens frequently enough to be considered a problem. Anyway, these stats are not considered to be updated with the most latest info. -- With Regards, Amit Kapila.