Dear Fujii-san, I apologize for sending bad patches... I confirmed that it can be built and passed a test.
> Could you tell me why you added new paragraph into the middle of existing > paragraph? This change caused the following error when compiling the docs. > > postgres-fdw.sgml:952: parser error : Opening and ending tag mismatch: > listitem > line 934 and para > </para> > > How about adding that new paragraph just after the existing one, instead? Fixed. > + /* > + * The parsing result became an empty string, > + * and that means other "application_name" > will be used > + * for connecting to the remote server. > + * So we must set values[i] to an empty string > + * and search the array again. > + */ > + values[i] = ""; > > Isn't pfree() necessary inside the loop also when data[0]=='\0' case? If so, > probably "data" would need to be set to NULL just after pfree(). Otherwise > pfree()'d "data" can be pfree()'d again at the end of connect_pg_server(). I confirmed the source, and I agreed your argument because initStringInfo() allocates memory firstly. Hence pfree() was added. > Thanks! But, since the term "local server" is already used in the docs, we > can use > "the setting value of application_name in local server" etc? I like the word "local server," so I reworte descriptions. Best Regards, Hayato Kuroda FUJITSU LIMITED
v25_0002_allow_escapes.patch
Description: v25_0002_allow_escapes.patch
v25_0001_update_descriptions.patch
Description: v25_0001_update_descriptions.patch
