On Wed, Dec 22, 2021 at 5:39 PM houzj.f...@fujitsu.com <houzj.f...@fujitsu.com> wrote: > > On Wed, Dec 22, 2021 11:36 AM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > On Tue, Dec 21, 2021 at 10:24 PM Amit Kapila <amit.kapil...@gmail.com> > > wrote: > > The patch looks mostly good to me. > I only have few comments. > > 1) > +/* > + * Do parallel index bulk-deletion with parallel workers. > + */ > +void > +parallel_vacuum_bulkdel_all_indexes(ParallelVacuumState *pvs, long > num_table_tuples) > +{ > + Assert(!IsParallelWorker()); > + > > Would it be better to also put Assert(pvs != NULL) here ? Because we removed > the Assert(ParallelVacuumIsActive(vacrel)) check in the old function. >
I am not sure if that is helpful or not because there is only one caller of it which checks pvs before calling this function. > > 2) > +#include "utils/rel.h" > +#include "utils/lsyscache.h" > +#include "utils/memutils.h" > > It might be better to keep the header file in alphabetical order. > : > +#include "utils/lsyscache.h" > +#include "utils/memutils.h" > +#include "utils/rel.h" > Right, I'll take care of this as I am already making some other edits in the patch. -- With Regards, Amit Kapila.