On Tue, Feb 8, 2022 at 8:01 AM houzj.f...@fujitsu.com <houzj.f...@fujitsu.com> wrote: > > > > > 12. src/backend/replication/pgoutput/pgoutput.c - get_rel_sync_entry > > > > + /* > > + * Initialize the row filter after getting the final publish_as_relid > > + * as we only evaluate the row filter of the relation which we publish > > + * change as. > > + */ > > + pgoutput_row_filter_init(data, active_publications, entry); > > > > The comment "which we publish change as" seems strangely worded. > > > > Perhaps it should be: > > "... only evaluate the row filter of the relation which being published." > > Changed. >
I don't know if this change is an improvement. If you want to change then I don't think 'which' makes sense in the following part of the comment: "...relation which being published." Few other comments: ==================== 1. Can we save sending schema change messages if the row filter doesn't match by moving maybe_send_schema after row filter checks? 2. commit message/docs: "The WHERE clause only allows simple expressions that don't have user-defined functions, user-defined operators, user-defined collations, non-immutable built-in functions, or references to system columns." "user-defined types" is missing in this sentence. 3. + /* + * For all the supported nodes, check the functions and collations used in + * the nodes. + */ Again 'types' is missing in this comment. -- With Regards, Amit Kapila.
