On Wed, Feb 9, 2022 at 7:07 AM Peter Smith <smithpb2...@gmail.com> wrote: > > 2. src/backend/commands/publicationcmds.c - > contain_mutable_or_ud_functions_checker > > +/* check_functions_in_node callback */ > +static bool > +contain_mutable_or_user_functions_checker(Oid func_id, void *context) > +{ > + return (func_volatile(func_id) != PROVOLATILE_IMMUTABLE || > + func_id >= FirstNormalObjectId); > +} > > I was wondering why is the checking for user function and mutable > functions combined in one function like this. IMO it might be better > to have 2 "checker" callback functions instead of just one - then the > error messages can be split too so that only the relevant one is > displayed to the user. >
For that, we need to invoke the checker function multiple times for a node and or expression. So, not sure if it is worth it. -- With Regards, Amit Kapila.