On Thu, Mar 10, 2022 at 12:50:15PM -0800, Andres Freund wrote: > > - setup_cores_script: | > > + setup_os_script: | > > mkdir -m 770 /tmp/cores > > chown root:postgres /tmp/cores > > sysctl kern.corefile='/tmp/cores/%N.%P.core' > > + #pkg install -y ... > > Would you mind if I split this into setup_core_files_script and > setup_additional_packages_script:?
That's fine. FYI I'm also planning on using choco install --no-progress I could resend my latest patches shortly. > > Subject: [PATCH 6/7] wip: cirrus/windows: add compiler_warnings_script > > > > I'm not sure how to write this test in windows shell; it's also not easy to > > write it in posix sh, since windows shell is somehow interpretting && and > > ||... > > That comment isn't accurate anymore now that it's in an external script, > right? No, it is accurate. What I mean is that it's also hard to write it as a 1-liner using posix sh, since the || (and &&) seemed to be interpretted by cmd.exe and needed escaping - gross. -- Justin