On Sat, Feb 12, 2022 at 12:52:40PM +0900, Michael Paquier wrote: > On Fri, Feb 11, 2022 at 10:07:49AM -0500, Robert Haas wrote: > > Over in > > http://postgr.es/m/CA+TgmoYUDEJga2qV_XbAZ=pgebaosgfmzz6ac4_srwom_+u...@mail.gmail.com > > I was noticing that CreateWalTarMethod doesn't support LZ4 > > compression. It would be nice if it did. I thought maybe the patch on > > this thread would fix that, but I think maybe it doesn't, because it > > looks like that's touching the WalDirectoryMethod part of that file, > > rather than the WalTarMethod part. Is that correct? > > Correct. pg_receivewal only cares about the directory method, so this > thread was limited to this part. Yes, it would be nice to extend > fully the tar method of walmethods.c to support LZ4, but I was not > sure what needed to be done, and I am still not sure based on what has > just been done as of 751b8d23. > > > And, on a related note, Michael, do you plan to get something > > committed here? > > Apart from f79962d, babbbb5 and 50e1441, I don't think that there was > something left to do for this thread. Perhaps I am missing something?
I think this should use <lz4frame.h> +#include "lz4frame.h" commit babbbb595d2322da095a1e6703171b3f1f2815cb Author: Michael Paquier <mich...@paquier.xyz> Date: Fri Nov 5 11:33:25 2021 +0900 Add support for LZ4 compression in pg_receivewal -- Justin