On Sat, Apr 7, 2018 at 1:58 PM, Amit Langote <amitlangot...@gmail.com> wrote: > On Sat, Apr 7, 2018 at 1:31 PM, Andres Freund <and...@anarazel.de> wrote: >> I've not followed this thread/feature at all, but I don't find the >> comments atop partprune.c even remotely sufficient. Unless there's an >> README hidden or such hidden somewhere? > > Sorry there isn't a README and I agree partprune.c's header comment > could be improved quite a bit. > > Just to be clear, that's the fault of the patch that was already > committed earlier today (9fdb675fc "Faster partition pruning"), not > this patch, which just extends partition.c's functionality to > implement additional planner and executor support for runtime pruning. > > I'm drafting a patch that expands the partprune.c comment and will post > shortly.
See if the attached makes it any better. Now I know we don't have the runtime pruning in yet, but since the proposed patch would extend its functionality I have included its description in the comment. Thanks, Amit
expand-partprune-header-comment.patch
Description: Binary data
