Hi, On 2022-04-14 13:36:51 -0400, Tom Lane wrote: > What if the reason we need a snapshot is to detoast some toasted item > we read from a catalog with the CatalogSnapshot? There might not be > any other valid snapshot, so I don't think I buy your argument here.
We definitely do have places doing that, but is it ever actually safe? Part of the catalog access might cause cache invalidations to be processed, which can invalidate the snapshot (including resetting MyProc->xmin). Afaics we always would have push or register the snapshot, either will copy the snapshot, I think? Greetings, Andres Freund
