On Tuesday, May 17, 2022 2:53 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > Few minor comments: > ================== > 1. > + <para> > + Names of table columns included in the publication. This contains all > + the columns of table when user didn't specify column list for the > + table. > + </para></entry> > > Can we slightly change it to: "Names of table columns included in the > publication. This contains all the columns of the table when the user > didn't specify the column list for the table." > > 2. Below comments needs to be removed from tablesync.c as we don't > combine column lists after this patch. > > * For initial synchronization, column lists can be ignored in following > * cases: > * > * 1) one of the subscribed publications for the table hasn't specified > * any column list > * > * 2) one of the subscribed publications has puballtables set to true > * > * 3) one of the subscribed publications is declared as ALL TABLES IN > * SCHEMA that includes this relation > > 3. > Note that we don't support the case where column list is different for > + * the same table when combining publications. But we still need to check > + * all the given publication-table mappings and report an error if any > + * publications have different column list. > > Can we change this comment to: "Note that we don't support the case > where the column list is different for the same table when combining > publications. But one can later change the publication so we still > need to check all the given publication-table mappings and report an > error if any publications have a different column list."? > > 4. Can we add a test for different column lists if it is not already there?
Thanks for the comments. Attach the new version patch which addressed all the above comments and comments from Shi yu[1] and Osumi-san[2]. [1] https://www.postgresql.org/message-id/OSZPR01MB6310F32344884F9C12F45071FDCE9%40OSZPR01MB6310.jpnprd01.prod.outlook.com [2] https://www.postgresql.org/message-id/TYCPR01MB83736AEC2493FCBB75CC7556EDCE9%40TYCPR01MB8373.jpnprd01.prod.outlook.com Best regards, Hou zj
v3-0001-Extend-pg_publication_tables-to-display-column-list-.patch
Description: v3-0001-Extend-pg_publication_tables-to-display-column-list-.patch
v3-0002-Prohibit-combining-publications-with-different-colum.patch
Description: v3-0002-Prohibit-combining-publications-with-different-colum.patch
