On Monday, May 16, 2022 9:34 PM houzj.f...@fujitsu.com <houzj.f...@fujitsu.com> wrote: > Attach the new version patch. Hi,
I have few minor comments. For v2-0001. (1) Unnecessary period at the end of column explanation + <row> + <entry role="catalog_table_entry"><para role="column_definition"> + <structfield>rowfilter</structfield> <type>text</type> + </para> + <para> + Expression for the table's publication qualifying condition. + </para></entry> + </row> It seems when we write a simple noun to explain a column, we don't need to put a period at the end of the explanation. Kindly change FROM: "Expression for the table's publication qualifying condition." TO: "Expression for the table's publication qualifying condition" For v2-0002. (a) typo in the commit message Kindly change FROM: "In both cases, it doesn't seems to make sense to combine column lists." TO: "In both cases, it doesn't seem to make sense to combine column lists." or "In both cases, it doesn't make sense to combine column lists." (b) fetch_table_list + if (list_member(tablelist, rv)) + ereport(ERROR, + errcode(ERRCODE_FEATURE_NOT_SUPPORTED), + errmsg("cannot use different column lists for table \"%s.%s\" in different publications", + nspname, relname)); Kindly add tests for new error paths, when we add them. Best Regards, Takamichi Osumi