On Wed, May 4, 2022 2:47 PM vignesh C <vignes...@gmail.com> wrote: > > Thanks for the comments, the attached v13 patch has the changes for the same. >
Thanks for your patch. Here are some comments on v13-0001 patch. 1) @@ -152,6 +152,18 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl </listitem> </varlistentry> + <varlistentry> + <term><literal>local_only</literal> (<type>boolean</type>)</term> + <listitem> + <para> + Specifies whether the subscription will request the publisher to send + locally originated changes at the publisher node, or send any + publisher node changes regardless of their origin. The default is + <literal>false</literal>. + </para> + </listitem> + </varlistentry> + <varlistentry> <term><literal>slot_name</literal> (<type>string</type>)</term> <listitem> I think this change should be put after "The following parameters control the subscription's replication behavior after it has been created", thoughts? 2) A new column "sublocalonly" is added to pg_subscription, so maybe we need add it to pg_subscription document, too. (in doc/src/sgml/catalogs.sgml) 3) /* * Currently we always forward. */ static bool pgoutput_origin_filter(LogicalDecodingContext *ctx, RepOriginId origin_id) Should we modify the comment of pgoutput_origin_filter()? It doesn't match the code. Regards, Shi yu