On Tue, Apr 10, 2018 at 3:46 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > > Julien Rouhaud <rjuju...@gmail.com> writes: >> I think the best fix if to define NO_GENERATED_HEADERS in pgxs.mk, >> patch attached. > > Hm. I wonder if we don't also want NO_TEMP_INSTALL, like the doc/src/sgml > makefile. I don't know whether "make check" could be useful in a PGXS > build, but certainly that recipe for making a temp install isn't gonna > work.
If I understand correctly, PGXS.mk already forbids a "make check" if PGXS is defined. And it seems that postgres' contribs rely on including PGXS.mk, setting NO_PGXS and doing a "make check", so NO_TEMP_INSTALL shouldn't be needed.
