On 06.05.22 23:27, Andres Freund wrote:
I added pkgconfig since then. They're not exactly the same, but pretty close,
except for one thing: Looks like some of the ecpg libraries really should link
to some other ecpg libs? I think we're missing something there... That then
leads to missing requirements in the .pc files.
I took a closer look at the generated pkgconfig files. I think they are
ok. There are a couple of insignificant textual differences that we
could reduce by patching Makefile.shlib. But technically they are ok.
There is one significant difference: the ecpg libraries now get a
Requires.private for openssl, which I think is technically correct since
both libpgcommon and libpgport require openssl.
Attached is a tiny patch to make the description in one file backward
consistent.From 8320c520e01b52933f6688e210ffa9cdfdefffe9 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut <pe...@eisentraut.org>
Date: Tue, 31 May 2022 20:46:20 +0200
Subject: [PATCH] fixup! meson: Add meson based buildsystem.
Fix description in pkg-config file for backward consistency.
---
src/interfaces/ecpg/compatlib/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/interfaces/ecpg/compatlib/meson.build
b/src/interfaces/ecpg/compatlib/meson.build
index 3cd61217e3..84cd42ccee 100644
--- a/src/interfaces/ecpg/compatlib/meson.build
+++ b/src/interfaces/ecpg/compatlib/meson.build
@@ -11,6 +11,6 @@ ecpg_compat = both_libraries('ecpg_compat',
pkgconfig.generate(
ecpg_compat.get_shared_lib(),
name: 'libecpg_compat',
- description: 'PostgreSQL ecpg_compat library',
+ description: 'PostgreSQL libecpg_compat library',
url: pg_url,
)
--
2.36.1
