On Tue, Jul 5, 2022 at 4:33 AM Dilip Kumar <dilipbal...@gmail.com> wrote: > I thought about this comment from Robert > > that's not quite the same as either of those things. For example, in > > tableam.h we currently say "This callback needs to create a new > > relation filenode for `rel`" and how should that be changed in this > > new naming? We're not creating a new RelFileNumber - those would need > > to be allocated, not created, as all the numbers in the universe exist > > already. Neither are we creating a new locator; that sounds like it > > means assembling it from pieces. > > I think that "This callback needs to create a new relation storage > for `rel`" looks better.
I like the idea, but it would sound better to say "create new relation storage" rather than "create a new relation storage." -- Robert Haas EDB: http://www.enterprisedb.com
