Andres Freund <and...@anarazel.de> writes: > Thanks. Next in my quest for reducing autoconf vs meson pg_config.h > differences is GETTIMEOFDAY stuff.
I just noticed that this could be simplified: #ifdef _MSC_VER struct timezone; /* Last parameter not used */ extern int gettimeofday(struct timeval *tp, struct timezone *tzp); #endif because what POSIX actually says is int gettimeofday(struct timeval *restrict tp, void *restrict tzp); and If tzp is not a null pointer, the behavior is unspecified. Indeed, we never call it with anything but a null tzp value, nor does our Windows fallback implementation do anything with tzp. So ISTM we should drop the bogus "struct timezone;" and declare this parameter as "void *tzp". regards, tom lane