Thomas Munro <thomas.mu...@gmail.com> writes: > On Sun, Aug 7, 2022 at 11:22 AM Tom Lane <t...@sss.pgh.pa.us> wrote: >> Thomas Munro <thomas.mu...@gmail.com> writes: >>> I also wonder if half the stuff in win32gettimeofday.c can be deleted.
> This looks good on CI (well I haven't waited for it to finish yet, but > MSVC compiles it without warning and we're most of the way through the > tests...). Looks plausible from here. A couple other thoughts: * While you're at it you could fix the "MinW" typo just above the extern for gettimeofday. * I'm half tempted to add something like this to gettimeofday: /* * POSIX declines to define what tzp points to, saying * "If tzp is not a null pointer, the behavior is unspecified". * Let's take this opportunity to verify that noplace in * Postgres tries to use any unportable behavior. */ Assert(tzp == NULL); regards, tom lane