On 8/23/22 01:53, Drouvot, Bertrand wrote:
> That sounds all good to me, except a typo for the author in the commit 
> message: s/Jocob/Jacob/

Thanks, I missed that on my readthrough! :D

Patch looks good to me, too, with one question:

> @@ -2688,6 +2689,7 @@ InitProcessGlobals(void)                                
>    
>     MyProcPid = getpid();                                                     
>    
>     MyStartTimestamp = GetCurrentTimestamp();                                 
>    
>     MyStartTime = timestamptz_to_time_t(MyStartTimestamp);                    
>    
> +   memset(&MyClientConnectionInfo, 0, sizeof(MyClientConnectionInfo));       
>    
>                                                                               
>    
>     /*                                                                        
>    
>      * Set a different global seed in every process.  We want something 

When can we rely on static initialization, and when can't we? Is there a
concern that the memory could have been polluted from before the
postmaster's fork?

Thanks,
--Jacob


Reply via email to