On Mon, Aug 29, 2022 at 10:57 AM David Rowley <dgrowle...@gmail.com> wrote: > > After a bit more revision, mostly updating outdated comments and > naming adjustments, I've pushed this. > > Per the benchmark results I showed in [1], due to the performance of > having the AllocSet free list pointers stored at the end of the > allocated chunk being quite a bit slower than having them at the start > of the chunk, I adjusted the patch to have them at the start. > > Time for me to go and watch the buildfarm results come in. >
There is a BF failure with a callstack: 2022-08-29 03:29:56.911 EDT [1056:67] pg_regress/ddl STATEMENT: SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'include-xids', '0', 'skip-empty-xacts', '1'); TRAP: FailedAssertion("pointer == (void *) MAXALIGN(pointer)", File: "../../../../src/include/utils/memutils_internal.h", Line: 120, PID: 1056) 0x1e6f71c <ExceptionalCondition+0x9c> at postgres 0x1ea8494 <MemoryContextAllowInCriticalSection.part.0> at postgres 0x1ea9ee8 <repalloc> at postgres 0x1c56dc4 <ReorderBufferCleanupTXN+0xbc> at postgres 0x1c58a1c <ReorderBufferProcessTXN+0x1980> at postgres 0x1c44c5c <xact_decode+0x46c> at postgres 0x1c445f0 <LogicalDecodingProcessRecord+0x98> at postgres 0x1c4b578 <pg_logical_slot_get_changes_guts+0x318> at postgres 0x1ad69ec <ExecMakeTableFunctionResult+0x268> at postgres 0x1aedc88 <FunctionNext+0x3a0> at postgres 0x1ad7808 <ExecScan+0x100> at postgres 0x1acaaa0 <standard_ExecutorRun+0x158> at postgres 0x1ceac3c <PortalRunSelect+0x2d0> at postgres 0x1cec8ec <PortalRun+0x16c> at postgres 0x1ce7b30 <exec_simple_query+0x3a4> at postgres 0x1ce96ec <PostgresMain+0x1720> at postgres 0x1c2c784 <PostmasterMain+0x1a3c> at postgres 0x1ee6a1c <main+0x248> at postgres I am not completely sure if the failure is due to your commit but it was showing the line added by this commit. Note that I had also committed (commit id: d2169c9985) one patch today but couldn't correlate the failure with that so thought of checking with you. There are other similar failures[2][3] as well but [1] shows the stack trace. Any idea? [1] - https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=mamba&dt=2022-08-29%2005%3A53%3A57 [2] - https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=grison&dt=2022-08-29%2008%3A13%3A09 [3] - https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skate&dt=2022-08-29%2006%3A13%3A24 -- With Regards, Amit Kapila.