(It seems to me I overlooked some mails.. sorry.) At Mon, 5 Sep 2022 15:47:37 -0700, Andres Freund <and...@anarazel.de> wrote in > On 2022-09-05 17:32:20 +0900, Kyotaro Horiguchi wrote: > > The rationale of creating them at pgstat_attach_shmem is that anyway once > > pgstat_attach_shmem is called, the process fainally creates the contexts at > > the end of the process, and (I think) it's simpler that we don't do if() > > check at every pgstat_get_entry_ref() call. > > But that's not true, as pointed out here: > https://postgr.es/m/20220808192020.nc556tlgcp66fdgw%40awork3.anarazel.de > > Nor does it make sense to reserve memory for the entire lifetime of a process > just because we might need it for a split second at the end.
Yeah, that's the most convincing argument aginst it. At Mon, 5 Sep 2022 14:46:55 +0200, "Drouvot, Bertrand" <bdrou...@amazon.com> wrote in > Looks like that both approaches have their pros and cons. I'm tempted > to vote +1 on "just changing" the parent context to TopMemoryContext > and not changing the allocations locations. Yeah. It is safe more than anything and we don't have a problem there. So, I'm fine with just replacing the parent context at the three places. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
