On Fri, Sep 16, 2022 at 12:06 PM Kyotaro Horiguchi <horikyota....@gmail.com> wrote: > > In other words, it seems to me that the macro name doesn't manifest > the condition correctly. > > I don't think we don't particularly want to do that unconditionally. > I wanted just to get rid of the macro from the usage site. Even if > the same condition is used elsewhere, I see it better to write out the > condition directly there..
I wanted to avoid a bit of duplicate code there. How about naming that macro IsXLOGSourceSwitchToStreamEnabled() or SwitchFromArchiveToStreamEnabled() or just SwitchFromArchiveToStream() or any other better name? -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
