I had quick look at the latest v11-0001 patch differences from v10. Here are some initial comments:
====== 1. Commit message It looks like some small mistake happened. You wrote [1] that my previous review comments about the commit message were fixed, but it seems the v11 commit message is unchanged since v10. ====== 2. src/backend/replication/logical/relation.c - GenerateDummySelectPlannerInfoForRelation +/* + * This is not a generic function, helper function for + * GetCheapestReplicaIdentityFullPath. The function creates + * a dummy PlannerInfo for the given relationId as if the + * relation is queried with SELECT command. + */ +static PlannerInfo * +GenerateDummySelectPlannerInfoForRelation(Oid relationId) "generic function, helper function" -> "generic function. It is a helper function" ------ [1] https://www.postgresql.org/message-id/CACawEhXnTcXBOTofptkgSBOyD81Pohd7MSfFaW0SKo-0oKrCJg%40mail.gmail.com Kind Regards, Peter Smith. Fujitsu Australia
