Hi Peter, Thanks for the quick response.
> 1. Commit message > > It looks like some small mistake happened. You wrote [1] that my > previous review comments about the commit message were fixed, but it > seems the v11 commit message is unchanged since v10. > > Oops, yes you are right, I forgot to push commit message changes. I'll incorporate all these suggestions on v12. > ====== > > 2. src/backend/replication/logical/relation.c - > GenerateDummySelectPlannerInfoForRelation > > +/* > + * This is not a generic function, helper function for > + * GetCheapestReplicaIdentityFullPath. The function creates > + * a dummy PlannerInfo for the given relationId as if the > + * relation is queried with SELECT command. > + */ > +static PlannerInfo * > +GenerateDummySelectPlannerInfoForRelation(Oid relationId) > > "generic function, helper function" -> "generic function. It is a > helper function" > > Fixed. I'll attach the changes in the next email with v12. Thanks, Onder
