Hi, On 2022-09-30 17:58:31 +0200, Vik Fearing wrote: > On 9/7/22 12:03, Dave Page wrote: > > Here's a v4 patch. This reverts to using > > GetCurrentTransactionStopTimestamp() for the last_scan times, and will > > set xactStopTimestamp the first time GetCurrentTransactionStopTimestamp() > > is called, thus avoiding multiple gettimeofday() calls. > > SetCurrentTransactionStopTimestamp() is removed, as is use > > of xactStopTimestamp (except when resetting it to 0). > > This patch looks good to me and has much saner behavior than what it > replaces.
I agree. However, it seems like a significant enough behavioural change that I'd rather commit it as a separate patch. I agree with Vik's judgement that the patch otherwise is otherwise ready. Happy to do that split myself, or you can do it... Greetings, Andres Freund
