On 2022-Oct-27, Michael Paquier wrote: > On Thu, Sep 29, 2022 at 08:09:56PM -0700, Nathan Bossart wrote: > > Looks reasonable to me. > > 0001, to move pg_pwritev_with_retry() to a new home, seems fine, so > applied.
Maybe something a bit useless, but while perusing the commits I noticed a forward struct declaration was moved from one file to another; this is claimed to avoid including port/pg_iovec.h in common/file_utils.h. We do that kind of thing in a few places, but in this particular case it seems a bit of a pointless exercise, since pg_iovec.h doesn't include anything else and it's a quite simple header. So I'm kinda proposing that we only do the forward struct initialization dance when it really saves on things -- in particular, when it helps avoid or reduce massive indirect header inclusion. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
>From c170367e5ac7dca2dcd11b5cbb6d351b1b205842 Mon Sep 17 00:00:00 2001 From: Alvaro Herrera <alvhe...@alvh.no-ip.org> Date: Sun, 30 Oct 2022 15:22:24 +0100 Subject: [PATCH] No need to avoid including pg_iovec.h --- src/include/common/file_utils.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/include/common/file_utils.h b/src/include/common/file_utils.h index 2c5dbcb0b1..20fe5806fb 100644 --- a/src/include/common/file_utils.h +++ b/src/include/common/file_utils.h @@ -15,6 +15,8 @@ #include <dirent.h> +#include "port/pg_iovec.h" + typedef enum PGFileType { PGFILETYPE_ERROR, @@ -24,7 +26,6 @@ typedef enum PGFileType PGFILETYPE_LNK } PGFileType; -struct iovec; /* avoid including port/pg_iovec.h here */ #ifdef FRONTEND extern int fsync_fname(const char *fname, bool isdir); @@ -40,7 +41,7 @@ extern PGFileType get_dirent_type(const char *path, int elevel); extern ssize_t pg_pwritev_with_retry(int fd, - const struct iovec *iov, + const iovec *iov, int iovcnt, off_t offset); -- 2.30.2