Hi Nikita, > Please don't forget to run `pgindent` before formatting the patches > with `git format-patch` next time.
There are also some compiler warnings, please see the attachment. > I'm going to submit a more detailed code review soon. -- Best regards, Aleksander Alekseev
/home/eax/projects/pgscripts/../postgresql/src/backend/access/heap/heaptoast.c: In function ‘heap_compute_data_size_without_attr’: /home/eax/projects/pgscripts/../postgresql/src/backend/access/heap/heaptoast.c:90:19: warning: ‘tmp’ may be used uninitialized [-Wmaybe-uninitialized] 90 | *pvalue = PointerGetDatum(&tmp); | ^~~~~~~~~~~~~~~~~~~~~ In file included from /home/eax/projects/pgscripts/../postgresql/src/backend/access/heap/heaptoast.c:25: /home/eax/projects/pgscripts/../postgresql/src/include/postgres.h:735:1: note: by argument 1 of type ‘const void *’ to ‘PointerGetDatum’ declared here 735 | PointerGetDatum(const void *X) | ^~~~~~~~~~~~~~~ /home/eax/projects/pgscripts/../postgresql/src/backend/access/heap/heaptoast.c:85:24: note: ‘tmp’ declared here 85 | struct varlena tmp; | ^~~