On Wed, Dec 28, 2022 at 4:17 PM Peter Eisentraut <peter.eisentr...@enterprisedb.com> wrote: > > Most callers of BufFileRead() want to check whether they read the full > specified length. Checking this at every call site is very tedious. > This patch provides additional variants BufFileReadExact() and > BufFileReadMaybeEOF() that include the length checks. > > I considered changing BufFileRead() itself, but this function is also > used in extensions, and so changing the behavior like this would create > a lot of problems there. The new names are analogous to the existing > LogicalTapeReadExact(). >
+1 for the new APIs. I have noticed that some of the existing places use %m and the file path in messages which are not used in the new common function. -- With Regards, Amit Kapila.
