On Tuesday, January 31, 2023 8:23 AM Peter Smith <smithpb2...@gmail.com> wrote: > > On Mon, Jan 30, 2023 at 5:23 PM houzj.f...@fujitsu.com > <houzj.f...@fujitsu.com> wrote: > > > > On Monday, January 30, 2023 12:13 PM Peter Smith > <smithpb2...@gmail.com> wrote: > > > > > > Here are my review comments for v88-0002. > > > > Thanks for your comments. > > > > > > > > ====== > > > General > > > > > > 1. > > > The test cases are checking the log content but they are not > > > checking for debug logs or untranslated elogs -- they are expecting > > > a normal ereport LOG that might be translated. I’m not sure if that is > > > OK, or > if it is a potential problem. > > > > We have tests that check the ereport ERROR and ereport WARNING > > message(by search for the ERROR or WARNING keyword for all the tap > > tests), so I think checking the LOG should be fine. > > > > > ====== > > > doc/src/sgml/config.sgml > > > > > > 2. > > > On the publisher side, logical_replication_mode allows allows > > > streaming or serializing changes immediately in logical decoding. > > > When set to immediate, stream each change if streaming option (see > > > optional parameters set by CREATE SUBSCRIPTION) is enabled, > > > otherwise, serialize each change. When set to buffered, the decoding > > > will stream or serialize changes when logical_decoding_work_mem is > reached. > > > > > > 2a. > > > typo "allows allows" (Kuroda-san reported same) > > > > > > 2b. > > > "if streaming option" --> "if the streaming option" > > > > Changed. > > Although you replied "Changed" for the above, AFAICT my review comment > #2b. was accidentally missed.
Fixed. Best Regards, Hou zj
