On Thu, May 10, 2018 at 8:30 AM, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: > > How about we error out even *before* calling DefineIndex for the 1st time? > I see that ProcessUtilitySlow() gets a list of all partitions when > locking them for index creation before calling DefineIndex. Maybe, just > go through the list and error out if one of them is a partition that we > don't support creating an index on?
+1 for the idea. We don't want to spend efforts in DefineIndex for some relations only to throw away that work later. I quickly looked at the patch and I think it's on right track. -- Best Wishes, Ashutosh Bapat EnterpriseDB Corporation The Postgres Database Company
