On Fri, Feb 17, 2023, at 21:26, Andres Freund wrote: > Removing the free_var()s from numeric_add_opt_error() speeds it up from ~361ms > to ~338ms.
I notice numeric_add_opt_error() is extern and declared in numeric.h, called from e.g. timestamp.c and jsonpath_exec.c. Is that a problem, i.e. is there a risk it could be used in a for loop by some code outside Numeric? > This code really needs some memory management overhead reduction love. Many > allocation could be avoided by having a small on-stack "buffer" that's used > unless the numeric is large. Nice idea! Could something like the attached patch work? /Joel
0001-fixed-buf.patch
Description: Binary data
