Hi, On 2023-02-26 14:51:45 -0500, Tom Lane wrote: > Andres Freund <and...@anarazel.de> writes: > > On 2022-12-08 16:15:11 -0800, Andres Freund wrote: > >> The most frequent case is postgres_fdw, which somewhat regularly fails > >> with a > >> regression.diff like this: > >> WHERE application_name = 'fdw_retry_check'; > >> pg_terminate_backend > >> ---------------------- > >> - t > >> -(1 row) > >> +(0 rows) > > > Unless somebody comes up with a way to make the test more reliable pretty > > soon, I think we should just remove it. It's one of the most frequently > > flapping tests at the moment. > > If that's the only diff, we could just hide it, say by writing > > do $$ begin > PERFORM pg_terminate_backend(pid, 180000) FROM pg_stat_activity > WHERE application_name = 'fdw_retry_check'; > end $$; > > The actually important thing is the failure check after this; > we don't care that much whether the initially-created connection > is still live at this point.
Hm, yea, that should work. It's indeed the entirety of the diff https://api.cirrus-ci.com/v1/artifact/task/4718859714822144/testrun/build/testrun/postgres_fdw-running/regress/regression.diffs If we go that way we can remove the debug_discard muckery as well, I think? Greetings, Andres Freund
