On 14 May 2018 at 16:49, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: > On 2018/05/11 18:43, Amit Khandekar wrote: >> This looks better (it will avoid unnecessary ExecConstraints() call) : >> >> if (resultRelInfo->ri_PartitionRoot == NULL || >> (resultRelInfo->ri_TrigDesc && >> resultRelInfo->ri_TrigDesc->trig_insert_before_row)) >> check_partition_constr = resultRelInfo->ri_PartitionCheck; > > You'd be assigning a List pointer to a bool variable with this. Maybe you > meant: > > check_partition_constr = (resultRelInfo->ri_PartitionCheck != NIL);
I also noticed that. Apart from that, I think your version is correct, but I just don't think it's quite as easy to understand. Although that's certainly debatable. For now, I'll refrain from writing v4 unless there's some consensus that this is a better way to write it. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
