On Wed, Mar 15, 2023 at 3:33 PM Melih Mutlu <m.melihmu...@gmail.com> wrote: > > Amit Kapila <amit.kapil...@gmail.com>, 15 Mar 2023 Çar, 12:31 tarihinde şunu > yazdı: >> >> On Tue, Mar 14, 2023 at 4:32 PM Melih Mutlu <m.melihmu...@gmail.com> wrote: > > >> >> What purpose does this test serve w.r.t this patch? Before checking >> the sync for different column orders, the patch has already changed >> binary to false, so it doesn't seem to test the functionality of this >> patch. Am, I missing something? > > > I missed that binary has changed to false before testing column orders. I > moved that test case up before changing binary to false. > Please see v14 [1]. >
After thinking some more about this test, I don't think we need this test as this doesn't add any value to this patch. This tests the column orders which is well-established functionality of the apply worker. -- With Regards, Amit Kapila.
