On Mon, Jul 24, 2023 at 01:50:45PM +0530, Bharath Rupireddy wrote: > I disagree with removing SQL tests from the worker_spi module. As said > upthread, it makes the worker_spi a fully demonstrable > extension/module - one can just take it, start adding required > functionality and test-cases (both SQL and TAP) for a new module.
Which is basically the same thing with TAP except that these are grouped now? The value of a few raw SQL queries with a NO_INSTALLCHECK does not strike me as enough on top of having to maintain two different sets of tests. I'd still choose the cheap and extensible path here. > I agree that moving to TAP tests will reduce test run time by 1.9 > seconds, but to me personally this is not an optimization we must be > doing at the expense of demonstrability. In a large parallel run, the difference can be felt. -- Michael
signature.asc
Description: PGP signature