On Wed, Sep 20, 2023 at 04:54:36PM +0530, Amit Kapila wrote: > Is the check to ensure remote_lsn is valid correct in function > check_for_subscription_state()? How about the case where the apply > worker didn't receive any change but just marked the relation as > 'ready'?
I may be missing, of course, but a relation is switched to SUBREL_STATE_READY only once a sync happened and its state was SUBREL_STATE_SYNCDONE, implying that SubscriptionRelState->lsn is never InvalidXLogRecPtr, no? For instance, nothing happens when a Assert(!XLogRecPtrIsInvalid(rstate->lsn)) is added in process_syncing_tables_for_apply(). -- Michael
signature.asc
Description: PGP signature