On Wed, Sep 20, 2023 at 11:28:33AM +0000, Hayato Kuroda (Fujitsu) wrote: > Good catch, I could not notice because it worked well in my RHEL. Here is the > updated version.
I am getting slowly up to date with this patch.. But before going in depth with more review, there is something that I got to ask: why is there no option to control if the slots are copied across the upgrade? At least, I would have imagined that an option to disable the copy of the slots would be adapted, say a --no-slot-copy or similar to get back to the old behavior if need be. + * This is because before that the logical slots are not saved at shutdown, so + * there is no guarantee that the latest confirmed_flush_lsn is saved to disk Is this comment in get_old_cluster_logical_slot_infos() still true after e0b2eed047d? -- Michael
signature.asc
Description: PGP signature
